Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Expressions] Fix expressions execution unit test to use fake timers for reliability #99952

Merged
merged 1 commit into from
May 13, 2021
Merged

[Expressions] Fix expressions execution unit test to use fake timers for reliability #99952

merged 1 commit into from
May 13, 2021

Conversation

dokmic
Copy link
Contributor

@dokmic dokmic commented May 12, 2021 •
edited
Loading

Summary

Fix expressions execution unit test to use fake timers for reliability.

Resolves #98102.

Checklist

@dokmic dokmic added review Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) v8.0.0 Team:AppServices v7.14.0 labels May 12, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dokmic dokmic marked this pull request as ready for review May 12, 2021 18:52
@dokmic dokmic requested a review from a team as a code owner May 12, 2021 18:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@dokmic dokmic added the release_note:skip Skip the PR/issue when compiling release notes label May 12, 2021
tsullivan
tsullivan approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dokmic dokmic merged commit 91136c9 into elastic:master May 13, 2021
@dokmic dokmic deleted the bugfix/98102 branch May 13, 2021 07:44
@dokmic dokmic mentioned this pull request May 13, 2021
Merged
dokmic added a commit to dokmic/kibana that referenced this pull request May 13, 2021
@dokmic
[Expressions] Fix expressions execution unit test to use fake timers …
ca39e81 
…for reliability (elastic#99952)
dokmic added a commit that referenced this pull request May 13, 2021
@dokmic
[Expressions] Fix expressions execution unit test to use fake timers …
6554b9c 
…for reliability (#99952) (#100016)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsullivan tsullivan tsullivan approved these changes

Assignees
No one assigned
Labels
Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) release_note:skip Skip the PR/issue when compiling release notes review v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
4 participants
@dokmic @kibanamachine @elasticmachine @tsullivan